fix: Exclude Readme.md files from file locking in the text app#8284
fix: Exclude Readme.md files from file locking in the text app#8284juliusknorr merged 7 commits intonextcloud:mainfrom
Conversation
rikled
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
silverkszlo
left a comment
silverkszlo
left a comment
There was a problem hiding this comment.
I've tested this by adding temporary debug logging and saw the following output in the nextcloud log, so seems to work :)
{"message":"Attempting to lock file","data":{"fileId":"89","fileName":"regular.md"}}
{"message":"Lock result","data":{"fileId":"89","fileName":"regular.md","isLocked":"true"}}
{"message":"Skipping lock for file","data":{"fileId":"86","fileName":"Readme.md","reason":"Readme.md exception"}}
Signed-off-by: Hendrik Leidinger <[email protected]>
Signed-off-by: Hendrik Leidinger <[email protected]>
Signed-off-by: Hendrik Leidinger <[email protected]>
Signed-off-by: Hendrik Leidinger <[email protected]>
Signed-off-by: Hendrik Leidinger <[email protected]>
Signed-off-by: Hendrik Leidinger <[email protected]>
Signed-off-by: Hendrik Leidinger <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/8284/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8a86356a 6d9d7fbd de24ab74 84434b95 3fff0180 e845b5b3 c99bcaee
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8284/stable31Error: Failed to push branch backport/8284/stable31: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable33 |
|
/backport to stable32 |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/8284/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8a86356a 6d9d7fbd de24ab74 84434b95 3fff0180 e845b5b3 c99bcaee
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8284/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
@mejo- could you please create a manual backport for stable31 too? Thanks a lot! |
5 participants
📝 Summary
This PR excludes Readme files from file locking. Without it is almost impossible to delete these files as they are opened as soon as a user visits the directory of the file. This is meant as an intermediate solution until #5597 is implemented.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)